Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Upgrade Ember from 3.22.0 to 3.23.0 (PIX-2067). #2469

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

lisequesnel
Copy link
Contributor

@lisequesnel lisequesnel commented Jan 28, 2021

🦄 Problème

On a un utilisateur qui a certainement rencontré un problème avec les query params dans l'url : on a eu des requêtes très bizarre de ce type :

/api/campaigns/{id}/assessment-participations?campaignId={id}&filter[divisions]="\"\\\"[\\\\\\\"5A\\\\\\\"]\\\"\""

On a vu qu'il y avait une issue Ember emberjs/ember.js#14174 qui ressemble très fortement à notre problème.
Cette issue semble résolue et inclue dans la version 3.23.0 de Ember : https://blog.emberjs.com/ember-3-23-released/ (emberjs/ember.js#19249 & emberjs/ember.js#19236)

🤖 Solution

Monter de version 3.22.0 à 3.23.0.

🌈 Remarques

le linter a changé de version majeure, il a fallu :

  • supprimer "plugin:ember/octane"
  • corriger certaines erreurs de lint (des nouvelles règles)

💯 Pour tester

Non régression

@lisequesnel lisequesnel changed the title [ORGA] Upgrade Ember from 3.22.0 to 3.23.0 (PIX-2067). [BUGFIX/TECH] Upgrade Ember from 3.22.0 to 3.23.0 (PIX-2067). Jan 28, 2021
@lisequesnel lisequesnel added the cross-team Toutes les équipes de dev label Jan 28, 2021
@lisequesnel lisequesnel changed the title [BUGFIX/TECH] Upgrade Ember from 3.22.0 to 3.23.0 (PIX-2067). [BUGFIX] Upgrade Ember from 3.22.0 to 3.23.0 (PIX-2067). Jan 28, 2021
@pix-service
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cross-team Toutes les équipes de dev Func Review OK PO validated functionally the PR 🚀 Ready to Merge team-prescription Tech Review OK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants